-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
combobox 🚸 tweaks for single select #3124
Conversation
- hide the selected value when inputing text - delete input value on blur (you must actually select something with intent to select it, this prevents the field from "looking like it's filled in when it's actually not")
🦋 Changeset detectedLatest commit: e3f1b0c The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 58cd4ca0bc | 88 komponenter | 139 stories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like filtered search is preserved onBlur, making previous search like "app" be the default after re-entering the field.
https://github.com/user-attachments/assets/c5a8f201-b685-4116-8cb2-0fe21e5abcbf
Reproduce:
- "Default" combobox-story
- write and select "banana"
- write "app"
- tab -> shift + tab to blur -> re-enter field
- now shows results for "app" again
nice catch! (turns out I shouldn't have shied away from |
Description
Closes https://github.com/navikt/team-aksel/issues/577
This + #3071 Closes #2891
Change summary
Versioning 🏷️
yarn changeset
to generate a version-entry for change.