🐛 Combobox: trailing spaces are no longer accepted autocomplete-letters #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a388497 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
larseirikhansen
changed the title
Storybook demo9c17425c1 | 88 komponenter | 139 stories |
KenAJoh
approved these changes
Aug 21, 2024
| return list.find((listItem) => | ||
| normalizeText(listItem.label).startsWith(normalizedText), | ||
| normalizeText(listItem.label).startsWith(text.toLocaleLowerCase()), |
There was a problem hiding this comment.
Suggested change
| normalizeText(listItem.label).startsWith(text.toLocaleLowerCase()), | |
| // We deliberately avoid using `normalizeText()` to avoid trimming input | |
| normalizeText(listItem.label).startsWith(text.toLocaleLowerCase()), |
HalvorHaugan
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found this bug a while ago. The bug: After triggering autocomplete, adding a trailing space will continue the suggestion. For example, writing "ap " (with two trailing spaces) will be interpreted as having written "appl", given that the first autocomplete suggestion is "apple". Spaces almost function as a wildcard. A letter after the space(s) stops the behaviour.
This fix: trailing spaces no longer work as wildcards in autocomplete. They still work as spaces for multiple words.
Discussion:
With this fix, writing spaces still don't filter out items in the dropdown (like writing a letter will). So adding a space after a word won't remove all results that don't include that space. This might be convenient in some cases, but it also allows for confusing edge cases like this:
Here, the third (instead of the first) option in the dropdown is the autocomplete suggestion. Is the fact that the autocomplete result is not always on top more confusing than it is convenient? If so, I will make space like letters