🩹 Combobox: placeholder fix #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dbd5b38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demo86990f26a | 88 komponenter | 139 stories |
it-vegard
reviewed
Aug 15, 2024
| <UNSAFE_Combobox {...props} id="combobox" /> | ||
| <UNSAFE_Combobox | ||
| {...props} | ||
| maxSelected={{ limit: Number(props.maxSelected) }} |
There was a problem hiding this comment.
Hvorfor maxSelected på default-eksempelet?
There was a problem hiding this comment.
Tried to test edge cases, like having that prop active in Storybook. But it didn't work from the Storybook-controls, so that was the fix 👍
Co-authored-by: Halvor Haugan <[email protected]>
HalvorHaugan
approved these changes
Aug 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original issue afaik: https://nav-it.slack.com/archives/C7NE7A8UF/p1714377788972099
With this fix, the placeholder of the Combobox input-element is no longer visible if the user has added a value to selectedOptions (i.e. picked a value from the dropdown or added a custom value). This took a while because of internal discussions of the placeholder prop in Combobox.