Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox: Can no longer remove options with backspace when shouldShowSelectedOptions is false #3076

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

HalvorHaugan
Copy link
Contributor

Reproduce in story MultiSelectWithExternalChips. Pressing backspace should not remove selected options if shouldShowSelectedOptions={false}.

Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: 7f6a6d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch
@navikt/aksel Patch
@navikt/aksel-stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Storybook demo

e31d94797 | 87 komponenter | 130 stories

Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended 🙌

@HalvorHaugan HalvorHaugan merged commit 779e30d into main Aug 7, 2024
4 checks passed
@HalvorHaugan HalvorHaugan deleted the combobox-ext-chips-fix branch August 7, 2024 10:48
@github-actions github-actions bot mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants