Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated font support and definition #3044

Merged
merged 3 commits into from
Aug 5, 2024
Merged

feat: Updated font support and definition #3044

merged 3 commits into from
Aug 5, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Jul 9, 2024

Description

  • Added built-in support for cyrillic, cyrillic-ext and latin-ext
  • Changed font-name used internally to SourceSans3. This change will not break old use of SourceSansPro since we keep its definition.

Copy link

changeset-bot bot commented Jul 9, 2024

🦋 Changeset detected

Latest commit: 3f3a56b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-tokens Minor
@navikt/ds-css Minor
@navikt/ds-react Minor
@navikt/ds-tailwind Minor
@navikt/aksel-stylelint Minor
@navikt/aksel Minor
@navikt/aksel-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Storybook demo

Endringer til review: 9

993e79322 | 87 komponenter | 130 stories

@JulianNymark
Copy link
Contributor

JulianNymark commented Jul 10, 2024

Små forskjeller i bredde på noen av de spesielle tegnene kan bety breaking? (om en tittel plutselig wrapper ned til 2 linjer og slikt). Ser en liten forskjell i noen av storybook demo eksempel diff over.

@HalvorHaugan
Copy link
Contributor

Looks like font-weight:500 gives bold text now, but not sure if it matters? (According to Chromatic)

@KenAJoh
Copy link
Collaborator Author

KenAJoh commented Aug 5, 2024

Små forskjeller i bredde på noen av de spesielle tegnene kan bety breaking? (om en tittel plutselig wrapper ned til 2 linjer og slikt). Ser en liten forskjell i noen av storybook demo eksempel diff over.

Could in theory happen if they have hard-coded some widths, but would be suprised if this broke anything.

@KenAJoh
Copy link
Collaborator Author

KenAJoh commented Aug 5, 2024

Looks like font-weight:500 gives bold text now, but not sure if it matters? (According to Chromatic)

Yes since we set a font-range from "400 600" every weight between those two will now work, and not snap to closest available. Could see this changing a few instances, but since it is only 100 weight difference i recon few will notice it if they have used "font-weight 500". Did a git-search and found a few cases, but some of those also used different fonts so might not actually change anything 🤷

As for allowing 500 weight, when discussed with brand they said it was ok for now as long as we still only recommend/use 400 and 600 internally.

@HalvorHaugan
Copy link
Contributor

I have a few things I would like to discuss/suggest about the stories, when you have time,

@KenAJoh KenAJoh merged commit 8fd183c into main Aug 5, 2024
4 checks passed
@KenAJoh KenAJoh deleted the font-update-lang branch August 5, 2024 07:34
@github-actions github-actions bot mentioned this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants