-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated font support and definition #3044
Conversation
🦋 Changeset detectedLatest commit: 3f3a56b The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 9993e79322 | 87 komponenter | 130 stories |
Små forskjeller i bredde på noen av de spesielle tegnene kan bety breaking? (om en tittel plutselig wrapper ned til 2 linjer og slikt). Ser en liten forskjell i noen av storybook demo eksempel diff over. |
Looks like font-weight:500 gives bold text now, but not sure if it matters? (According to Chromatic) |
Could in theory happen if they have hard-coded some widths, but would be suprised if this broke anything. |
Yes since we set a font-range from "400 600" every weight between those two will now work, and not snap to closest available. Could see this changing a few instances, but since it is only 100 weight difference i recon few will notice it if they have used "font-weight 500". Did a git-search and found a few cases, but some of those also used different fonts so might not actually change anything 🤷 As for allowing 500 weight, when discussed with brand they said it was ok for now as long as we still only recommend/use 400 and 600 internally. |
I have a few things I would like to discuss/suggest about the stories, when you have time, |
Description