Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement BasePrimitive for Box, Stack and HGrid #3003

Merged
merged 26 commits into from
Jun 19, 2024
Merged

Implement BasePrimitive for Box, Stack and HGrid #3003

merged 26 commits into from
Jun 19, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Jun 12, 2024

Description

  • Added margin-prop for BasePrimitive
  • Split Box-features into classNames
  • Added AsChild to Box

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d02308d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/aksel-stylelint Minor
@navikt/aksel Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 13, 2024 •
edited
Loading

Storybook demo

794b15f04 | 85 komponenter | 160 stories

@KenAJoh KenAJoh marked this pull request as ready for review June 14, 2024 07:12
@KenAJoh KenAJoh changed the title [WIP] Implement BasePrimitive for Box, Stack and HGrid Implement BasePrimitive for Box, Stack and HGrid Jun 14, 2024
HalvorHaugan
HalvorHaugan reviewed Jun 17, 2024
View reviewed changes
@navikt/core/react/src/layout/base/BasePrimitive.stories.tsx Outdated Show resolved Hide resolved
@navikt/core/css/primitives/base.css Outdated Show resolved Hide resolved
@navikt/core/react/src/layout/base/BasePrimitive.tsx Outdated Show resolved Hide resolved
@navikt/core/react/src/layout/base/BasePrimitive.tsx Outdated Show resolved Hide resolved
@navikt/core/react/src/layout/base/BasePrimitive.tsx Outdated Show resolved Hide resolved
.changeset/silly-shrimps-peel.md Outdated Show resolved Hide resolved
@navikt/core/react/src/layout/base/PrimitiveWithAsChild.ts Outdated Show resolved Hide resolved
@navikt/core/react/src/layout/base/PrimitiveWithAsChild.ts Outdated Show resolved Hide resolved
@navikt/core/react/src/layout/box/Box.tsx Outdated Show resolved Hide resolved
HalvorHaugan
HalvorHaugan previously approved these changes Jun 19, 2024
View reviewed changes
@KenAJoh KenAJoh merged commit b38789b into main Jun 19, 2024
4 checks passed
@KenAJoh KenAJoh deleted the implement-baseprimitive branch June 19, 2024 09:17
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulianNymark JulianNymark JulianNymark left review comments

@HalvorHaugan HalvorHaugan HalvorHaugan left review comments

Assignees
No one assigned
Labels
Ready for review 🧙
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KenAJoh @JulianNymark @HalvorHaugan