Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Radio og Checkbox bruker :focus #2893

Merged
merged 1 commit into from
May 2, 2024
Merged

refactor: Radio og Checkbox bruker :focus #2893

merged 1 commit into from
May 2, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented May 2, 2024

Dette gir bedre synlighet når de blir lenket til fra ErrorSummary (med pointer-event og ikke keyboard)

Description

I de tilfellene bruker ble sendt til f.eks checkbox gjennom lenke + anchor/id med musepeker fikk ikke komponenten fokusmarkering. Dette kunne i noen tilfeller gjøre at det ikke var like oversiktelig hvor bruker ble sendt gjennom lenke, spesielt hvis skjerm ikke scroller til element.

@KenAJoh KenAJoh requested review from JulianNymark and it-vegard May 2, 2024 09:44
Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: 4715382

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-css Patch
@navikt/aksel-stylelint Patch
@navikt/aksel Patch
@navikt/ds-react Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 2, 2024

Storybook demo

Endringer til review: 2

b6bf352cf | 63 komponenter | 204 stories

Copy link
Contributor

@JulianNymark JulianNymark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KenAJoh KenAJoh merged commit db9c858 into main May 2, 2024
2 checks passed
@KenAJoh KenAJoh deleted the form-focus branch May 2, 2024 10:18
@github-actions github-actions bot mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants