Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progressbar tweaks (etter docs-møtet) #2892

Merged
merged 34 commits into from
May 7, 2024
Merged

Progressbar tweaks (etter docs-møtet) #2892

merged 34 commits into from
May 7, 2024

Conversation

larseirikhansen
Copy link
Contributor

Flere mindre endringer:

  • Lagt til onIndeterminate callback i APIet som trigger når duration er ferdig
  • Tydeligere aria-valuetext
  • Ymse småendringer i demoer til dokumentasjon
  • Slettet en tidligere slettet demofil som snek seg med i en merge fra main

@larseirikhansen
made demos
6efe481
@larseirikhansen
Merge remote-tracking branch 'origin/main' into progressbar-demos
1d64853
@larseirikhansen
ammend demo order
36992ad
@larseirikhansen
name change :usedInForm to interactive
0cdb64c
@larseirikhansen
move setRandomInterval into useEffect bc of sandbox
11cc9e9
@larseirikhansen
spacing in jsx for visibility
44bf235
@larseirikhansen
change div style to vstack
83426d2
@larseirikhansen
gac remove static variant
bc764ff
@larseirikhansen
change demo index
9251503
@larseirikhansen
change name from loading bar to loading
3f0c720
@larseirikhansen
button gap and progress carousel
87b661a
@larseirikhansen
change demo labels to norwegian
8a2e023
@larseirikhansen
change demo labels and layout
ed04a52
@larseirikhansen
change aria-label interactive demo
16e91e9
@larseirikhansen
Merge remote-tracking branch 'origin/main' into progressbar-demos
ec4ace1
@larseirikhansen
remove references to forms
5c3381b
@larseirikhansen
add onIndeterminate to API, tweak demos, delete duplicate file
295c877
@larseirikhansen
Merge remote-tracking branch 'origin/main' into progressbar-tweaks
1d754ec
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: af2f0d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/aksel-stylelint Patch
@navikt/aksel Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2024 •
edited
Loading

Storybook demo

15194ee6e | 63 komponenter | 164 stories

JulianNymark
JulianNymark previously approved these changes Apr 30, 2024
View reviewed changes
@navikt/core/react/src/progress-bar/ProgressBar.tsx Outdated Show resolved Hide resolved
@larseirikhansen larseirikhansen merged commit 0c06fa1 into main May 7, 2024
3 checks passed
@larseirikhansen larseirikhansen deleted the progressbar-tweaks branch May 7, 2024 12:36
@github-actions github-actions bot mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenAJoh KenAJoh KenAJoh left review comments

@HalvorHaugan HalvorHaugan HalvorHaugan approved these changes

@JulianNymark JulianNymark JulianNymark left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larseirikhansen @JulianNymark @KenAJoh @HalvorHaugan