Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Ny komponent: ProgressBar #2845

Merged
merged 59 commits into from
Apr 24, 2024
Merged

✨ Ny komponent: ProgressBar #2845

merged 59 commits into from
Apr 24, 2024

Conversation

larseirikhansen
Copy link
Contributor

@larseirikhansen larseirikhansen commented Apr 12, 2024

Description

Ny ProgressBar-komponent! Kan blant annet brukes til lasting av sider og søknadssider for å indikere hvor langt man har kommet.

Issue: https://github.com/orgs/navikt/projects/49/views/18?pane=issue&itemId=24133303

New component? ✨

  • Check that component-styling is correctly configured in @navikt/core/css/config/_mappings.js. This is needed for correct build and CDN upload.
  • Check that styling is correctly exported from @navikt/core/css/index.css
  • Check that correct tokens for component is documented in @navikt/core/css/tokens.json
  • Check that only needed components and types are exported from @navikt/core/react/src/index.ts
  • Add JSDoc to component (see other components for reference)
  • Create storybook-stories for relevant component variations and compositions. Stories are used for visual regression testing, so make sure they are complete.

Versioning 🏷️

  • Run yarn changeset to generate a version-entry for change.
    • New feature: Minor

Copy link

changeset-bot bot commented Apr 12, 2024

🦋 Changeset detected

Latest commit: 5d5409f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/aksel-stylelint Minor
@navikt/aksel Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 12, 2024

Storybook demo

Endringer til review: 1

44e1ce00f | 63 komponenter | 204 stories

@navikt/core/css/progress-bar.css Outdated Show resolved Hide resolved
@navikt/core/css/progress-bar.css Outdated Show resolved Hide resolved
@navikt/core/css/progress-bar.css Outdated Show resolved Hide resolved
@navikt/core/css/progress-bar.css Outdated Show resolved Hide resolved
@KenAJoh

This comment was marked as resolved.

HalvorHaugan
HalvorHaugan previously approved these changes Apr 24, 2024
@larseirikhansen larseirikhansen merged commit 277525f into main Apr 24, 2024
2 checks passed
@larseirikhansen larseirikhansen deleted the progressbar branch April 24, 2024 12:18
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants