-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ new FormSummary component #2802
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to be used in 2 places where we iterate over children and add <hr /> components between them all. It also wraps the children in a <Box>, which is used here and not really reflected in the name of the function 🤔
🦋 Changeset detectedLatest commit: f7f80f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 1d5c7cebad | 61 komponenter | 201 stories |
KenAJoh
reviewed
Apr 2, 2024
aksel.nav.no/website/pages/eksempler/formsummary/editlink-variation.tsx
Outdated
Show resolved
Hide resolved
KenAJoh
reviewed
Apr 15, 2024
KenAJoh
reviewed
Apr 15, 2024
@navikt/core/react/src/form/form-summary/FormSummaryHeading.tsx
Outdated
Show resolved
Hide resolved
KenAJoh
reviewed
Apr 15, 2024
KenAJoh
approved these changes
Apr 15, 2024
KenAJoh
approved these changes
Apr 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The form summary shows a summary of the form! 😎 (will become a pattern as well maybe?) But this is just the component.
TODO