🐛 Textarea: Sett riktig høyde når brukt i Modal + StrictMode #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 95498b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demo5de3b42f4 | 61 komponenter | 402 stories |
KenAJoh
approved these changes
Jan 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fiks for #2671
Feilen ble innført i #2457
(Mest sannsynlig det at ResizeObserver ikke lenger fikk en debounced
handleResize())Selve fiksen er på linje 28 i TextareaAutoSize.tsx.
Fant aldri rot-årsaken, men det var trolig ikke én enkelt årsak. Det var flere endringer som så ut til å kunne fikse feilen. Symptomet var en mer eller mindre uendelig render-loop, sannsynligvis forårsaket av en kombinasjon av forhold. For eksempel hjalp det å fjerne flushSync. Men den fiksen jeg endte opp med er den "minst risikable" jeg fant.