Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V6] Fjernet z-index-modal token #2637

Merged
merged 6 commits into from
Jan 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tall-turtles-flow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@navikt/ds-tokens": major
---

Tokens: Fjernet token `--a-z-index-modal` da den ikke lengre blir konsumert i systemet.
1 change: 0 additions & 1 deletion @navikt/core/tokens/docs.json
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,6 @@
"z-index": [
{ "name": "--a-z-index-focus", "value": 10 },
{ "name": "--a-z-index-popover", "value": 1000 },
{ "name": "--a-z-index-modal", "value": 2000 },
{ "name": "--a-z-index-tooltip", "value": 3000 }
]
}
1 change: 0 additions & 1 deletion @navikt/core/tokens/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ module.exports = {
},
},
"z-index": {
modal: { value: 2000 },
popover: { value: 1000 },
focus: { value: 10 },
tooltip: { value: 3000 },
Expand Down
8 changes: 8 additions & 0 deletions v6-migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,14 @@ Alle klasser med `.navds-content-container`-prefix er fjernet

## Tokens

### Z-index

Fjernet `--a-z-index-modal`-token da systemet nå bruker native `dialog`-element.

(Unødvendig med codemod da bare 1 løsning bruker den: https://github.com/search?type=code&q=org%3Anavikt+a-z-index-modal)

### Breakpoint

Nytt brekkpunkt for 1440px `--a-breakpoint-2xl`. Alle primitives støtter også nå 2xl-brekkpunkt for responsive props.

For brukere av vår tailwind-config vil dette også si at `screen` er oppdatert. Dette vil overskrive default tailwind-config som er `1536px`, og de tilfellene der man manuelt har overskrevet f.eks `max-w-screen-2xl` til å være noe annet.
Expand Down