Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erstatte Radix tabs med egen implementasjon av Tabs og rowing-tabindex #2587

Closed
wants to merge 21 commits into from

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Jan 2, 2024

Description

Tar i bruk det nye descendants-apiet til å håndtere rowing-tabindex

Løser også det eldste issuet vi har: #1736

OBS: inneholder nå endringer fra både #2585 og #2586

TODO

  • Teste implementasjon 1-1 med dagens løsning. Skal fungere som en drop-in replacement
  • Sjekke at riktige aria-attrb blir satt på elementer
  • Teste "error"-state der feil value etc er satt
  • Fjerne gammel tabs
  • Fjerne radix-tabs fra dependencies

Copy link

changeset-bot bot commented Jan 2, 2024

⚠️ No Changeset found

Latest commit: 4a86936

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Storybook demo

Endringer til review: 15

f15a1c664 | 64 komponenter | 409 stories

@KenAJoh
Copy link
Collaborator Author

KenAJoh commented Jan 15, 2024

Kommer en oppdatert versjon av denne

@KenAJoh KenAJoh closed this Jan 15, 2024
@KenAJoh KenAJoh deleted the use-tabs branch October 10, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant