Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpansionCard divider #2566

Merged
merged 4 commits into from
Jan 4, 2024
Merged

ExpansionCard divider #2566

merged 4 commits into from
Jan 4, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Dec 18, 2023

Description

Resolves #2554
https://github.com/navikt/team-aksel/issues/397

Change summary

  • Expansioncard har nå en 1px border (::after) mellom header og innhold.
  • Setting av padding er endret for å bedre gjenbruk av tokens i komponent

Diskusjon:

  • La til en liten transition på border mellom hidden/visible på hover. Funker det?

Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: 5762267

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-css Patch
@navikt/aksel-stylelint Patch
@navikt/aksel Patch
@navikt/ds-react Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 18, 2023

Storybook demo

Endringer til review: 7

8381802f0 | 61 komponenter | 401 stories

@KenAJoh
Copy link
Collaborator Author

KenAJoh commented Jan 4, 2024

Synket og validert design med designer 🎨 ✅

@KenAJoh KenAJoh merged commit 1b71fe0 into main Jan 4, 2024
2 checks passed
@KenAJoh KenAJoh deleted the expansioncard-divider branch January 4, 2024 19:10
@github-actions github-actions bot mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Innspill til komponent]: <ExpansionCard /> Spacing mellom title, og content uten description
1 participant