Fix issue where clicking Combobox.FilteredOptions after scrolling caused the wrong element to be selected #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… virtual focus to be moved and the list to scroll to the top. Then, onPointerUp, we select the new element that has scrolled into position under the cursor.
🦋 Changeset detectedLatest commit: 147f4e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 80c8d1a611 | 61 komponenter | 400 stories |
KenAJoh
approved these changes
Dec 4, 2023
HalvorHaugan
approved these changes
Dec 4, 2023
it-vegard
deleted the
bugfix/combobox-clicking-option-after-scrolling-selects-wrong-option
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://nav-it.slack.com/archives/C7NE7A8UF/p1701437323067429
When clicking an element in Combobox.FilteredOptions after scrolling, the list scrolled to the top and the new element under the cursor was selected.
This onBlur triggered when clicking items in FilteredOptions, causing the virtual focus to be moved and the list to scroll to the top.
Change summary
Removed an onBlur that did not really have any use, but caused the mentioned bug.