Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileUpload.List #2535

Merged
merged 29 commits into from
Dec 6, 2023
Merged

FileUpload.List #2535

merged 29 commits into from
Dec 6, 2023

Conversation

torkjels
Copy link
Contributor

@torkjels torkjels commented Dec 1, 2023

Mangler:

  • Å returnere index eller lignende på onRetry og onDelete sånn at man kan slette én av flere duplikate filer?
  • Å laste ned fila når man trykker på den, eventuelt kalle onClick eller rendre a med href

Description

Change summary

PR Checklist 📝 (Remove fields after check!)

New component? ✨

  • Check that component-styling is correctly configured in @navikt/core/css/config/_mappings.js. This is needed for correct build and CDN upload.
  • Check that styling is correctly exported from @navikt/core/css/index.css
  • Check that correct tokens for component is documented in @navikt/core/css/tokens.json
  • Check that only needed components and types are exported from @navikt/core/react/src/index.ts
  • Add JSDoc to component (see other components for reference)
  • Create storybook-stories for relevant component variations and compositions. Stories are used for visual regression testing, so make sure they are complete.
  • Is the component sufficiently complex to warrant tests? Add some unit-tests for jest.

Component-updates 🎉

  • Revalidate if everything under New component is still accounted for
  • Deprecating/removing a CSS class? Add it to @navikt/aksel-stylelint/src/deprecations.ts with a suitable description. This helps stylelint-users keep their code clean and bug-free.

Documentation 📝

  • Add/update component-demos for component aksel.nav.no/website/pages/eksempler
  • Create/Update documentation in sanity if needed
    Note: Props, tokens and examples only updates to sanity on merge to main

Versioning 🏷️

  • Run yarn changeset to generate a version-entry for change.
    • Bug/hotfix: Patch
    • New feature: Minor
    • Breaking change: Major
  • Adding breaking changes? Consider adding a codemod for easier migration.
  • Breaking changes also needs documentation under "Migration"-page on website

Mangler:
- Å returnere index eller lignende på onRetry og onDelete sånn at man kan slette én av flere duplikate filer?
- Å laste ned fila når man trykker på den, eventuelt kalle onClick eller rendre a med href
Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: 104293e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@torkjels torkjels force-pushed the file-uploader_filelist branch 2 times, most recently from c6b42b8 to 406f6c1 Compare December 1, 2023 16:06
Mangler:
- Å returnere index eller lignende på onRetry og onDelete sånn at man kan slette én av flere duplikate filer?
- Å laste ned fila når man trykker på den, eventuelt kalle onClick eller rendre a med href
@torkjels torkjels force-pushed the file-uploader_filelist branch from 406f6c1 to da231db Compare December 1, 2023 16:10
@torkjels torkjels changed the base branch from file-uploader to main December 5, 2023 15:40
@torkjels torkjels changed the base branch from main to file-uploader December 5, 2023 15:41
@torkjels torkjels changed the base branch from file-uploader to main December 5, 2023 15:49
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Storybook demo

Endringer til review: 9

4c9db7470 | 62 komponenter | 410 stories

@torkjels torkjels changed the base branch from main to file-uploader December 5, 2023 15:59
@HalvorHaugan HalvorHaugan marked this pull request as ready for review December 6, 2023 15:50
@HalvorHaugan HalvorHaugan merged commit 624b0f3 into file-uploader Dec 6, 2023
1 check passed
@HalvorHaugan HalvorHaugan deleted the file-uploader_filelist branch December 6, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants