💄 DatePicker: Litt smalere inputfelt #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b346d61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 11ac8d52603 | 59 komponenter | 385 stories |
KenAJoh
approved these changes
Oct 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduserer size ned til 10 på DateInput når den brukes i DatePicker da 14 er unødvendig bredt (en dato er 10 tegn). Det gjør det bittelitt enklere å få plass til to datofelt ved siden av hverandre (feks. ved range-modus) og imo ser det litt penere ut. Må imidlertid beholde 14 i MonthPicker siden måned skrives med bokstaver ("september 2023" er 14 tegn).
Det viser seg forresten at inputen blir smalere i Firefox enn Chrome ved samme size (eller width i em for den del). Prøvde først size=8 (og 12 på monthpicker), men det ble bare akkurat bredt nok på Firefox, så tenkte det var best å være på den sikre siden og ha litt å gå på.