Added aria-hidden to AccordionContent when closed #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug where label text for Radio components is sometimes left out of the accessibility tree when being hidden/displayed by an Accordion Ref: https://nav-it.slack.com/archives/C7NE7A8UF/p1695723000232659
🦋 Changeset detectedLatest commit: e5513ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 17aa74a8b6 | 59 komponenter | 385 stories |
KenAJoh
approved these changes
Sep 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where label text for Radio components is sometimes left out of the accessibility tree when being hidden/displayed by an Accordion Ref: https://nav-it.slack.com/archives/C7NE7A8UF/p1695723000232659
Description
Radio labels inside of Accordions are sometimes left out of the accessibility tree in the latest version of Chrome.
Although it appears that this is an issue in Chrome, as it doesn't happen in other browsers or older versions of Chrome, we found a fix.
Change summary