Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 HGrid align-prop #2242

Merged
merged 3 commits into from
Sep 6, 2023
Merged

🎨 HGrid align-prop #2242

merged 3 commits into from
Sep 6, 2023

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Sep 5, 2023

Description

Ved bruk av HGrid i dag vil alltid child-elementer ha "stretch" for å bruke lik høyde. For å slipper custom css som f.eks height: fit-content på alle child-elementer, fikser align-items dette

Change summary

  • La til align prop med "start" | "center" | "end"
  • La til storybook-story for testing

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023

🦋 Changeset detected

Latest commit: c751635

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/aksel-stylelint Patch
@navikt/aksel Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Storybook demo

f5723fc3b | 54 komponenter | 358 stories

Copy link
Contributor

@larseirikhansen larseirikhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart 🧠 Ser bra ut

@KenAJoh KenAJoh merged commit 6f2325b into main Sep 6, 2023
@KenAJoh KenAJoh deleted the hgrid-justify branch September 6, 2023 13:04
@github-actions github-actions bot mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants