Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fikset lightmode-theming #2238

Merged
merged 6 commits into from
Sep 7, 2023
Merged

🐛 Fikset lightmode-theming #2238

merged 6 commits into from
Sep 7, 2023

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Sep 4, 2023

Description

Nesten theming fungerte ikke i dag. Dette påvirker nok de aller færreste, men ved bruk av Modal i InternalHeader brakk dette (ref)

Denne (midlertidige 🤞) løsningen resetter intern token som blir satt ved darkmode. Endringen er utformet slik at custom-theming fra bruker vil da presedens over den interne lightmode/darkmode themingen vi har internt

Change summary

  • Darkmode-theming overskriver ikke lengre semantiske farger, men heller interne tokens som kan resettes.
  • Ved bruk av data-theme="light" vil token settes til initial

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2023

🦋 Changeset detected

Latest commit: 8be4e74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-tokens Patch
@navikt/ds-css Patch
@navikt/ds-tailwind Patch
@navikt/aksel-stylelint Patch
@navikt/aksel Patch
@navikt/ds-react Patch
@navikt/aksel-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Storybook demo

78bdddf43 | 54 komponenter | 358 stories

@KenAJoh KenAJoh merged commit 4d96914 into main Sep 7, 2023
@KenAJoh KenAJoh deleted the token-lightmode branch September 7, 2023 10:45
@github-actions github-actions bot mentioned this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant