Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 ReadOnly-state for skjemakomponenter #2080

Merged
merged 28 commits into from
Jul 3, 2023
Merged

🎨 ReadOnly-state for skjemakomponenter #2080

merged 28 commits into from
Jul 3, 2023

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Jun 26, 2023

Description

Task

Legger til støtte for readonly-state i skjemakomponenter

Change summary

Skjemakomponenter har nå innebygd styling og state-handling for readonly.

  • Select, Switch, Checkbox og Radio bruker aria-readonly da disse ikke støtter native readonly
  • Label har nå også innebygd PadlockIcon for å bedre indikere at de er readonly
  • Fikset aria-invalid-bug der skjermlesere kunne tolke skjemaelement som "invalid" når de var aria-invalid="false"
  • La til console.warn ved bruk av required-prop som vi sterkt fraråder

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023

🦋 Changeset detected

Latest commit: 728f9d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-css Minor
@navikt/ds-react Minor
@navikt/aksel-stylelint Minor
@navikt/aksel Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2023

Endringer til review: 10

fa69185f8 | 45 komponenter | 278 stories

@JulianNymark
Copy link
Contributor

image
virker som det aria attributtet ikke er lovlig på radio?

@KenAJoh KenAJoh marked this pull request as ready for review July 3, 2023 09:52
@KenAJoh KenAJoh merged commit ae70bfa into main Jul 3, 2023
@KenAJoh KenAJoh deleted the readonlyforms branch July 3, 2023 10:37
@github-actions github-actions bot mentioned this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants