🎨 Helptext har nå en prop for wrapperClassName #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e450fae The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
larseirikhansen
approved these changes
Jun 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HelpText sin semantikk gjør det unødvendig komplisert å aligne den sammen den test (inline-block). På sikt bør nok komponenten gå gjennom en refactor, men for nå vil dette løse problemet.
La også til dynamisk max-width slik at helptext ikke vil gå helt ut i kantene på viewport på mobil
📝 PR Checklist
🧪 Are all variations and cases shown in the storybook stories? Stories are used for visual regression testing, so make sure they are complete.
Run
yarn changesetfor version and changelog generation