Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Innspill til komponent]: <ExpansionCard /> #1931

Closed
karl-run opened this issue Apr 21, 2023 · 2 comments · Fixed by #1944
Closed

[Innspill til komponent]: <ExpansionCard /> #1931

karl-run opened this issue Apr 21, 2023 · 2 comments · Fixed by #1944

Comments

@karl-run
Copy link
Contributor

karl-run commented Apr 21, 2023

Tilbakemelding

Jeg vil kunne provide a11y label via aria-labelledby isteden for å bli tvunget til å bruke aria-label.

Eksempel:

const headerId = `minUnikeId-${sykmeldingsId}`

<ExpansionCard aria-labelledby={headerId}>
    <ExpansionCard.Header id={headerId}>
        En tittel

Dagens props krever at aria-label er satt:
image

@KenAJoh
Copy link
Collaborator

KenAJoh commented Apr 21, 2023

Ser ut som det er godkjent syntax, så ser ikke noe i veien for det
@mortentollefsen Vet du om noen ulemper med aria-labelledby vs aria-label for section-elementer?

@mortentollefsen
Copy link

mortentollefsen commented Apr 21, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants