Replace ResultSet to RowDocument in AggregateResultJdbcConverter #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanhyeong
commented
Dec 9, 2024
| while (!resultSetHolder.isDone() && resultSetHolder.next()) { | ||
| Map<String, Object> entityMap = this.mapSingleTableRow( | ||
| persistentEntity, resultSetHolder.getResultSet()); | ||
| while (resultSet.next()) { |
There was a problem hiding this comment.
ref. spring-jdbc RowMapperResultSetExtractor
This extract makes ResultSet to List<T>.
We've managed the AggregateResult results in this method, I bring the iteration logic here.
IAM20
approved these changes
Dec 19, 2024
|
3.5.0 버전에 같이 반영합니다 |
chanhyeong
force-pushed
the
feature/replace-resultset-to-rowdocument
branch
from
a98983b to
241e954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
ResultSettoRowDocument, which used to fetch the DB value.The current change does not mean much right now, but I think it can be lead to use converter implementations of spring-data-jdbc.
DB 조회 값을 가져오는 부분을
ResultSet에서RowDocument로 변경합니다현재 변경으로는 당장 큰 의미가 있지는 않지만, spring-data-jdbc 의 converter 구현으로 변경이 가능할 것 같습니다