Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chunk to selectAllUuidsByWithoutAgent #83

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

sohyun-ku
Copy link
Contributor

related #76

@sohyun-ku sohyun-ku requested review from a team and junoyoon as code owners July 6, 2023 06:07
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Scavenger Test Results

158 files  158 suites   1m 32s ⏱️
265 tests 253 ✔️ 12 💤 0
279 runs  267 ✔️ 12 💤 0

Results for commit e0d780a.

♻️ This comment has been updated with latest results.

@sohyun-ku sohyun-ku self-assigned this Jul 11, 2023

jvmDao.deleteAllByCustomerIdAndUuids(customerId, agentStates.map { it.jvmUuid } + uuidsWithoutAgent)
do {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expect a lot of loops.
Instead of a nested while, how about a separate while?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in e0d780a

@sohyun-ku sohyun-ku force-pushed the feature/add-chunk-to-find-jvm-uuid-without-agent branch from c4b86cc to e0d780a Compare July 12, 2023 03:13
Copy link
Contributor

@taeyeon-Kim taeyeon-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sohyun-ku sohyun-ku merged commit 01a107e into develop Jul 12, 2023
@sohyun-ku sohyun-ku deleted the feature/add-chunk-to-find-jvm-uuid-without-agent branch July 12, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants