Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move entity to entity module #48

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Move entity to entity module #48

merged 3 commits into from
Mar 10, 2023

Conversation

junoyoon
Copy link
Collaborator

@junoyoon junoyoon commented Mar 8, 2023 •
edited
Loading

  • Rename Entities with Entity postfix
  • Move entities in api/collector into entity module to minimize the duplication

@junoyoon junoyoon requested a review from a team as a code owner March 8, 2023 16:54
@github-actions
Copy link

github-actions bot commented Mar 8, 2023 •
edited
Loading

Scavenger Test Results

156 files  156 suites   33s ⏱️
254 tests 242 ✔️ 12 💤 0 ❌
256 runs  244 ✔️ 12 💤 0 ❌

Results for commit 9b8ce99.

♻️ This comment has been updated with latest results.

@junoyoon junoyoon force-pushed the feature/modulize-entities branch 3 times, most recently from d4e9fce to 77e3337 Compare March 8, 2023 17:33
@junoyoon junoyoon changed the title [WIP] Move entity to entity module Move entity to entity module Mar 8, 2023
@junoyoon junoyoon force-pushed the feature/modulize-entities branch from 76facee to bb24def Compare March 9, 2023 01:56
@junoyoon junoyoon requested review from dbgsprw and kojandy March 9, 2023 01:57
taeyeon-Kim
taeyeon-Kim reviewed Mar 9, 2023
View reviewed changes
settings.gradle.kts Outdated Show resolved Hide resolved
@junoyoon junoyoon force-pushed the feature/modulize-entities branch from bb24def to 2f30481 Compare March 9, 2023 04:32
@junoyoon
Copy link
Collaborator Author

junoyoon commented Mar 9, 2023

수정했습니다.

@junoyoon
Copy link
Collaborator Author

junoyoon commented Mar 9, 2023

api 쪽이 문제 없는 지 모르겠군요.
@taeyeon-Kim 우리 개발 환경에 api 한번 배포해 볼까요?

@taeyeon-Kim
Copy link
Contributor

api 쪽이 문제 없는 지 모르겠군요. @taeyeon-Kim 우리 개발 환경에 api 한번 배포해 볼까요?

배포했습니다. 간단히 테스트해봤는데 별다른 이슈는 안보이더군요.. 그래도 하루정도 지켜보는건 어떨까요??

@junoyoon
Copy link
Collaborator Author

junoyoon commented Mar 9, 2023

옙.

@junoyoon junoyoon force-pushed the feature/modulize-entities branch from 2f30481 to ed9fb34 Compare March 9, 2023 08:35
taeyeon-Kim
taeyeon-Kim reviewed Mar 10, 2023
View reviewed changes
scavenger-collector/src/main/kotlin/com/navercorp/scavenger/util/SqlRayQueryLogEntryCreator.kt Outdated
Comment on lines 31 to 32
val list = listOf<String>()
list.iterator()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not being used, please delete it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@junoyoon junoyoon force-pushed the feature/modulize-entities branch from ed9fb34 to 9b8ce99 Compare March 10, 2023 02:30
@junoyoon junoyoon merged commit 7963cf2 into develop Mar 10, 2023
@junoyoon junoyoon deleted the feature/modulize-entities branch March 10, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taeyeon-Kim taeyeon-Kim taeyeon-Kim approved these changes

@dbgsprw dbgsprw Awaiting requested review from dbgsprw

@kojandy kojandy Awaiting requested review from kojandy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junoyoon @taeyeon-Kim