feat(option): Intent to ship boost.useCssRule #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement boost.useCssRule, which avoid setting element's style as inlined. Ref naver#2716
netil
added a commit
to netil/billboard.js
that referenced
this pull request
Jun 23, 2022
- Split related methods to style.ts - Expand applying to legend and Arc elements Ref naver#2736
netil
added a commit
that referenced
this pull request
Jun 23, 2022
- Split related methods to style.ts - Expand applying to legend and Arc elements Ref #2736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#2716
Details
Implement boost.useCssRule, which avoid setting element's style as inlined.
With
boost.useCssRuleoption set,<circle>,<text>nodes' inlined style will be removed and applied from the style's rule.