Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axis): Fix bar draw for inverted y/y2 axes #2520

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

netil
Copy link
Member

@netil netil commented Jan 25, 2022

Update getting y/y2 axes min value.
Side effect caused by #1323

Ref #2503

Issue

Details

bb.generate({
  data: {
    columns: [
	["data1", 30, 200, -100],
	["data2", 50, -50, 70]
    ],
    type: "bar",
    axes: {
	data1: "y",
	data2: "y2",
    }
  },
  axis: {
    y: {
	inverted: true
    },
    y2: {
	show: true,
	inverted: true
    }
  }
});

From the above option, will be drawn as:

Update getting y/y2 axes min value.
Side effect caused by naver#1323

Ref naver#2503
@netil netil added the bug label Jan 25, 2022
@netil netil added this to the Patch milestone Jan 25, 2022
@netil netil self-assigned this Jan 25, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 90.257% when pulling a507f1f on netil:inverted#2503 into d3cc268 on naver:master.

@netil netil merged commit 9d0fb70 into naver:master Jan 26, 2022
@netil netil deleted the inverted#2503 branch January 26, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants