Pass instance argument to callback options #989
Assignees
Labels
Comments
netil
pushed a commit
that referenced
this issue
Aug 2, 2019
# [1.10.0-next.1](https://github.com/naver/billboard.js/compare/1.9.5...1.10.0-next.1@next) (2019-08-02) ### Bug Fixes * **chart:** Correct the order to set '$' node values ([b97558c](b97558c)), closes [#994](#994) * **event:** Update determination condition ([736ba56](736ba56)), closes [#967](#967) * **radar:** Correct display of indexed axis ([9bac296](9bac296)), closes [#997](#997) * **text:** Correct text vertical align ([6debb55](6debb55)), closes [#982](#982) * **tooltip:** Correct tooltip on dynamic loading ([c24bddb](c24bddb)), closes [#963](#963) * **tooltip:** Fix on contents template ([419144f](419144f)), closes [#972](#972) ### Features * **axis:** Intent to ship y/y2 axis culling ([44c6c4c](44c6c4c)), closes [#915](#915) * **bubble:** Intent to ship dimension ([27df7c3](27df7c3)), closes [#484](#484) * **options:** Pass instance arg to callbacks ([61cf047](61cf047)), closes [#989](#989) * **radar:** Intent to ship axis.text.position ([1720ec2](1720ec2)), closes [#998](#998)
|
🎉 This issue has been resolved in version 1.10.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
netil
pushed a commit
that referenced
this issue
Aug 7, 2019
# [1.10.0](1.9.5...1.10.0) (2019-08-07) ### Bug Fixes * **axis:** Correct label text position ([9beacfe](9beacfe)), closes [#1011](#1011) * **chart:** Correct the order to set '$' node values ([b97558c](b97558c)), closes [#994](#994) * **color:** Correct to not set stroke ([f18aa35](f18aa35)), closes [#754](#754) [#872](#872) * **event:** Update determination condition ([736ba56](736ba56)), closes [#967](#967) * **flow:** Fix data points removal ([5463150](5463150)), closes [#1006](#1006) * **radar:** Correct display of indexed axis ([9bac296](9bac296)), closes [#997](#997) * **text:** Correct text vertical align ([6debb55](6debb55)), closes [#982](#982) * **tooltip:** Correct tooltip on dynamic loading ([c24bddb](c24bddb)), closes [#963](#963) * **tooltip:** Fix on contents template ([419144f](419144f)), closes [#972](#972) ### Features * **axis:** Intent to ship y/y2 axis culling ([44c6c4c](44c6c4c)), closes [#915](#915) * **bubble:** Intent to ship dimension ([27df7c3](27df7c3)), closes [#484](#484) * **options:** Pass instance arg to callbacks ([61cf047](61cf047)), closes [#989](#989) * **radar:** Intent to ship axis.text.position ([1720ec2](1720ec2)), closes [#998](#998)
|
🎉 This issue has been resolved in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Within callback option, there're needs to access instance itself.
Most of callbacks, currently are called in
chart.internalcontext, but the use ofinternal(which is private object) isn't appropriate way.Hence, it needs to facilitate the usage passing instance as argument.
All targeted callback options are:
Ref. #665
The text was updated successfully, but these errors were encountered: