Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize option after the .load() is called #3157

Closed
netil opened this issue Mar 29, 2023 · 0 comments
Closed

Resize option after the .load() is called #3157

netil opened this issue Mar 29, 2023 · 0 comments
Assignees
@netil
Labels
feature

Comments

@netil
Copy link
Member

netil commented Mar 29, 2023

Description

When new dataseries are loaded, depending the data names, legend area need more space to render.
Provide load API's option for auto resizing after the load.

chart.load({
    resizeAfter: true
});

Steps to check or reproduce

Mar-29-2023 11-39-56
@netil netil added the feature label Mar 29, 2023
@netil netil self-assigned this Mar 30, 2023
netil pushed a commit to netil/billboard.js that referenced this issue Mar 30, 2023
feat(api): Enhance resizeAfter for .load/unload APIs
c5122dc 
Set as default the resizing after .load() or .unload() is called.
To keep backward compatibility, add `resizeAfter` option to on/off this behavior.

Ref naver#3157
@netil netil mentioned this issue Mar 30, 2023
Merged
@netil netil closed this as completed in 33bbca4 Mar 30, 2023
netil pushed a commit to netil/billboard.js that referenced this issue Mar 31, 2023
refactor(api): make .load/unload() option 'resizeAfter' to default 'f…
6c5f961 
…alse'

To keep backward compatibility and prevent some unexpected behavior,
set resizeAfter's default to false.

Ref naver#3157
@netil netil mentioned this issue Mar 31, 2023
Merged
netil added a commit that referenced this issue Mar 31, 2023
@netil
refactor(api): make .load/unload() option 'resizeAfter' to default 'f…
995001c 
…alse' (#3161)

To keep backward compatibility and prevent some unexpected behavior,
set resizeAfter's default to false.

Ref #3157
github-actions bot pushed a commit that referenced this issue Mar 31, 2023
@semantic-release-bot
chore(release): 3.8.0-next.1 [skip ci]
e5490c8 
# [3.8.0-next.1](3.7.5...3.8.0-next.1) (2023-03-31)

### Bug Fixes

* **data:** fix break when whole dataseries are null ([#3134](#3134)) ([5d12c45](5d12c45)), closes [#3124](#3124)
* **options:** Fix handling for falsy data.types ([5eb731a](5eb731a)), closes [#3125](#3125)

### Features

* **api:** Enhance resizeAfter for .load/unload APIs ([33bbca4](33bbca4)), closes [#3157](#3157)
* **axis:** Intent to ship axis.x.inverted ([e193c0f](e193c0f)), closes [#3137](#3137)
* **module:** Support dual CJS/ESM package ([437c007](437c007)), closes [#2202](#2202)
* **padding:** Intent to ship padding='fit' ([d760a63](d760a63)), closes [#3118](#3118)
* **plugin:** Intent to ship TableView plugin ([215b611](215b611)), closes [#1873](#1873)
github-actions bot pushed a commit that referenced this issue Apr 13, 2023
@semantic-release-bot
chore(release): 3.8.0 [skip ci]
d760c08 
# [3.8.0](3.7.5...3.8.0) (2023-04-13)

### Bug Fixes

* **data:** fix break when whole dataseries are null ([#3134](#3134)) ([5d12c45](5d12c45)), closes [#3124](#3124)
* **grid:** fix redundant <rect> appends ([1039363](1039363)), closes [#3147](#3147)
* **options:** Fix handling for falsy data.types ([5eb731a](5eb731a)), closes [#3125](#3125)
* **sparkline:** Fix to work point.focus.only option ([65b3c1c](65b3c1c)), closes [#3171](#3171)

### Features

* **api:** Enhance resizeAfter for .load/unload APIs ([33bbca4](33bbca4)), closes [#3157](#3157)
* **axis:** Intent to ship axis.x.inverted ([e193c0f](e193c0f)), closes [#3137](#3137)
* **package:** extends root div interface for styling ([0a1fe08](0a1fe08)), closes [#3162](#3162) [#3163](#3163)
* **padding:** Intent to ship padding='fit' ([d760a63](d760a63)), closes [#3118](#3118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netil netil

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@netil