refactor(grid, regions): refactor to not redraw whole chart #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove .redrawWithoutRescale() and replace its call to grid/regions APIs directly to reduce performance burden - remove separated grid.x.ts, grid.y.ts files and merge into grid.ts Ref naver#3037
netil
pushed a commit
to netil/billboard.js
that referenced
this pull request
Apr 10, 2023
When grid API is called, empty <rect> elements are appended. Fix to not append unnecessary nodes. Ref naver#3147
netil
added a commit
that referenced
this pull request
Apr 10, 2023
When grid API is called, empty <rect> elements are appended. Fix to not append unnecessary nodes. Fix #3147
github-actions bot
pushed a commit
that referenced
this pull request
Apr 10, 2023
# [3.8.0-next.2](3.8.0-next.1...3.8.0-next.2) (2023-04-10) ### Bug Fixes * **grid:** fix redundant <rect> appends ([1039363](1039363)), closes [#3147](#3147) * **sparkline:** Fix to work point.focus.only option ([65b3c1c](65b3c1c)), closes [#3171](#3171) ### Features * **package:** extends root div interface for styling ([0a1fe08](0a1fe08)), closes [#3162](#3162) [#3163](#3163)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2023
# [3.8.0](3.7.5...3.8.0) (2023-04-13) ### Bug Fixes * **data:** fix break when whole dataseries are null ([#3134](#3134)) ([5d12c45](5d12c45)), closes [#3124](#3124) * **grid:** fix redundant <rect> appends ([1039363](1039363)), closes [#3147](#3147) * **options:** Fix handling for falsy data.types ([5eb731a](5eb731a)), closes [#3125](#3125) * **sparkline:** Fix to work point.focus.only option ([65b3c1c](65b3c1c)), closes [#3171](#3171) ### Features * **api:** Enhance resizeAfter for .load/unload APIs ([33bbca4](33bbca4)), closes [#3157](#3157) * **axis:** Intent to ship axis.x.inverted ([e193c0f](e193c0f)), closes [#3137](#3137) * **package:** extends root div interface for styling ([0a1fe08](0a1fe08)), closes [#3162](#3162) [#3163](#3163) * **padding:** Intent to ship padding='fit' ([d760a63](d760a63)), closes [#3118](#3118)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3037
Details