Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate throw error when bar range type & bubble dimension contains larger data length #3096

Closed
netil opened this issue Feb 16, 2023 · 0 comments
Assignees

Comments

@netil
Copy link
Member

netil commented Feb 16, 2023

Description

For bar ranged type and bubble dimension types, it needs specify an array of 2 length for each data point.
If erroneously specifying more than 2 length, it will throw error.

Mitigate throwing error regardless of data length will improve the usage.

{
    data: {
      type: "bar", // or "bubble"
      columns: [
          ["data1", 
              [350, 70, 60],  // <-- currently will throw error
              [230, 290],
              [200, 500]]
      ]
@netil netil self-assigned this Feb 16, 2023
netil pushed a commit to netil/billboard.js that referenced this issue Feb 16, 2023
… needed

Remove the strict length check to determine ranged data type
to mitigate unexpected error when data length exceeed.

Ref naver#3096
netil pushed a commit to netil/billboard.js that referenced this issue Feb 16, 2023
… needed

Remove the strict length check to determine ranged data type
to mitigate unexpected error when data length exceeed.

Ref naver#3096
@netil netil closed this as completed in 51603ec Feb 16, 2023
github-actions bot pushed a commit that referenced this issue Mar 6, 2023
## [3.7.5](3.7.4...3.7.5) (2023-03-06)

### Bug Fixes

* **bar:** Fix broken bar shape transition with grouped radius option ([600df46](600df46)), closes [#2642](#2642)
* **data:** Fix tooltip event bound when data.xSort=false set ([aa4afc3](aa4afc3)), closes [#3100](#3100)
* **data:** mitigate bar/bubble ranged data to handle data length than needed ([51603ec](51603ec)), closes [#3096](#3096)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant