Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stanford scale breaks on min: 0 #2999

Closed
dastrobu opened this issue Dec 15, 2022 · 2 comments
Closed

stanford scale breaks on min: 0 #2999

dastrobu opened this issue Dec 15, 2022 · 2 comments
Labels

Comments

@dastrobu
Copy link

Description

When setting the scale to start from 0, it breaks.

scale: {
          min: 0,
          max: 10
     },

Steps to check or reproduce

  1. Open https://naver.github.io/billboard.js/demo/#Plugins.StanfordDiagram
  2. edit the scale and set to:
         scale: {
           min: 0,
           max: 10000
      }
    

Actual:

image

Scale has no ticks anymore, and all points are green (no color coding anymore)

@netil
Copy link
Member

netil commented Dec 29, 2022

Hi @dastrobu, thanks for the report and it was reproducible.
I'll be checking the issue.

@habibi03336
Copy link

habibi03336 commented Jan 1, 2023

I have found that tick uses log scale.
Therefore, it is not reasonable to set domain start as 0, log(0) goes to -Infinity which makes impossible to make ticks.

netil pushed a commit to netil/billboard.js that referenced this issue Jan 9, 2023
Replace d3-scaleLog to d3-scaleSymLog to handle 0(zero)
for scale start value

Ref naver#2999
@netil netil added bug and removed need-investigate labels Jan 9, 2023
@netil netil closed this as completed in 02c4270 Jan 9, 2023
github-actions bot pushed a commit that referenced this issue Jan 9, 2023
# [3.7.0-next.3](3.7.0-next.2...3.7.0-next.3) (2023-01-09)

### Bug Fixes

* **plugin:** Fix stanford scale to accept 0 as min value ([02c4270](02c4270)), closes [#2999](#2999)
* **selection:** Fix selection w/point.focus.only=true & selection.multiple=false ([af93a8a](af93a8a)), closes [#2928](#2928) [#3013](#3013)
github-actions bot pushed a commit that referenced this issue Jan 11, 2023
# [3.7.0](3.6.3...3.7.0) (2023-01-11)

### Bug Fixes

* **axis:** Fix axis label overlap when has no data ([643357b](643357b)), closes [#2974](#2974)
* **axis:** fix axis.y/y2.tick.format context error ([54ee419](54ee419)), closes [#2976](#2976)
* **domain:** Fix wrong domain range setting ([b55b153](b55b153)), closes [#2962](#2962)
* **options:** Fix data.regions path rendering for category axis ([249d0ac](249d0ac)), closes [#2950](#2950)
* **plugin:** Fix stanford scale to accept 0 as min value ([02c4270](02c4270)), closes [#2999](#2999)
* **selection:** Fix selection w/point.focus.only=true & selection.multiple=false ([af93a8a](af93a8a)), closes [#2928](#2928) [#3013](#3013)
* **types:** Add missing param definition for gauge.label.format ([d663532](d663532)), closes [#2946](#2946)
* **types:** Fix to referenced but missing d3 types ([0b57454](0b57454)), closes [#2954](#2954) [#2961](#2961)
* **types:** Support dual module type.d in TS >= 4.7 ([143e491](143e491)), closes [#2952](#2952) [#2953](#2953)

### Features

* **api:** Enhance .export() to preserve fontStyle ([0809ae7](0809ae7)), closes [#2892](#2892)
* **arc:** Intent to ship arc.cornerRadius ([e8320cf](e8320cf)), closes [#2936](#2936)
* **tooltip:** Enhance passing ratio value for stacked area/bar ([9e7ff01](9e7ff01)), closes [#2921](#2921)
* **treemap:** Intent to ship treemap type ([9809ef1](9809ef1)), closes [#123](#123) [#3002](#3002) [#3004](#3004) [#3006](#3006) [#3007](#3007) [#3008](#3008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants