Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data label placement with inverted y/y2 axis #2700

Closed
michkami opened this issue May 25, 2022 · 1 comment
Closed

data label placement with inverted y/y2 axis #2700

michkami opened this issue May 25, 2022 · 1 comment
Labels
bug

Comments

@michkami
Copy link
Collaborator

Description

Current data label placement with not inverted y/y2 axis

  • data labels for values >== 0 are placed above the data point (above the zero line)
  • data labels for values < 0 are placed below the data point (below the zero line)
  • Exception Candlestick Chart
    • data labels for Low are placed at the bottom of the candle
    • data labels for High are placed at the top of the candle
  • Line Chart
    03 current_not_inverted_y_axis_label_placement
  • Bar Chart
    06 current_not_inverted_y_axis_label_placement_bar
  • Candlestick Chart
    09 current_not_inverted_y_axis_label_placement_candle

Current data label placement with inverted y/y2 axis

  • data labels for values >== 0 are placed above the data point (below the zero line)
  • data labels for values < 0 are placed below the data point (above the zero line)
  • Exception Candlestick Chart
    • data labels for Low are placed at the bottom of the candle
    • data labels for High are placed at the top of the candle
  • Line Chart
    01 current_inverted_y_axis_label_placement
  • Bar Chart
    04 current_inverted_y_axis_label_placement_bar
  • Candlestick Chart
    07 current_inverted_y_axis_label_placement_candle

Expected data label placement with inverted y/y2 axis

  • data labels for values >== 0 are placed below the data point (below the zero line)
  • data labels for values < 0 are placed above the data point (above the zero line)
  • Exception Candlestick Chart
    • data labels for Low are placed at the top of the candle
    • data labels for High are placed at the bottom of the candle
  • Line Chart
    02 fixed_inverted_y_axis_label_placement
  • Bar Chart
    05 fixed_inverted_y_axis_label_placement_bar
  • Candlestick Chart
    08 fixed_inverted_y_axis_label_placement_candle

In the end you can say that all data labels that are above the zero line should be placed above the data point and all data labels that are below the zero line should be placed below the data point.
Exception is the Candlestick Chart where the data labels are placed depending on High/Low.

Steps to check or reproduce

https://jsfiddle.net/michkami/oe9cLwhn/
@netil netil added the bug label May 30, 2022
@netil
Copy link
Member

netil commented May 30, 2022

Seems having inconsistency on inverted axis.

netil added a commit to netil/billboard.js that referenced this issue May 30, 2022
@netil
fix(data): Fix data label position on inverted axis
19bd350 
Adjust y coordinate values when axis is inverted

Ref naver#2700
@netil netil mentioned this issue May 30, 2022
Merged
@netil netil closed this as completed in b024d83 May 30, 2022
github-actions bot pushed a commit that referenced this issue Jun 9, 2022
@semantic-release-bot
chore(release): 3.5.0-next.1 [skip ci]
93aa145 
# [3.5.0-next.1](3.4.1...3.5.0-next.1) (2022-06-09)

### Bug Fixes

* **bar:** fix bar radius for zero value ([9aa7579](9aa7579)), closes [#2642](#2642)
* **build:** Fix this keyword transpile ([b65531a](b65531a)), closes [#2671](#2671) [#2664](#2664) [#2665](#2665) [#2666](#2666) [#2667](#2667)
* **data:** Fix data label position on inverted axis ([b024d83](b024d83)), closes [#2700](#2700)
* **grid:** Fix y grid to show for log axis type ([d0b8cbd](d0b8cbd)), closes [#2710](#2710)
* **plugin:** fix sparkline dimension & tooltip ([79e1ab7](79e1ab7)), closes [#2682](#2682)
* **plugin:** fix stanford tooltip formatting ([9a87464](9a87464)), closes [#2657](#2657)
* **resize:** Fix legend resize ([7df949b](7df949b)), closes [#2650](#2650)
* **scale:** fix getting tickOffset ([3091677](3091677)), closes [#2669](#2669)
* **size.axis:** fix truncated axis when has no data ([40f4b66](40f4b66)), closes [#2675](#2675)
* **types:** Fix `Chart.load({ json })` typing ([1bd4f4a](1bd4f4a)), closes [#2711](#2711)
* **types:** Fix the signature of the tick format callback for timeseries ([c9c76e5](c9c76e5)), closes [#2676](#2676)
* **types:** Fix the type for options.data.names ([e64f6bd](e64f6bd)), closes [#2677](#2677)
* **types:** Fix types for the tooltip contents callback ([a0c0355](a0c0355)), closes [#2693](#2693)
* **zoom:** fix wheel zoom feeling "stuck" when panning past the edge ([50ed640](50ed640)), closes [#2588](#2588) [#2648](#2648)

### Features

* **data:** Intent to ship data.labels.rotate ([7b7ee08](7b7ee08)), closes [#2662](#2662)
* **module:** Support dual CJS/ESM package ([437c007](437c007)), closes [#2202](#2202)
* **plugin:** Intent to ship TableView plugin ([215b611](215b611)), closes [#1873](#1873)
* **resize:** Intent to ship resize.timer ([#2712](#2712)) ([0a07de0](0a07de0)), closes [#2650](#2650)
github-actions bot pushed a commit that referenced this issue Jun 30, 2022
@semantic-release-bot
chore(release): 3.5.0 [skip ci]
3f47375 
# [3.5.0](3.4.1...3.5.0) (2022-06-30)

### Bug Fixes

* **bar:** fix bar radius for zero value ([9aa7579](9aa7579)), closes [#2642](#2642)
* **build:** Fix this keyword transpile ([b65531a](b65531a)), closes [#2671](#2671) [#2664](#2664) [#2665](#2665) [#2666](#2666) [#2667](#2667)
* **data:** Fix data label position on inverted axis ([b024d83](b024d83)), closes [#2700](#2700)
* **grid:** Fix y grid to show for log axis type ([d0b8cbd](d0b8cbd)), closes [#2710](#2710)
* **option:** Fix onresize/onresized call context ([3ef9684](3ef9684)), closes [#2726](#2726)
* **plugin, type:** fix TextOverlap type definition ([80cc3b7](80cc3b7))
* **plugin:** fix sparkline dimension & tooltip ([79e1ab7](79e1ab7)), closes [#2682](#2682)
* **plugin:** fix stanford tooltip formatting ([9a87464](9a87464)), closes [#2657](#2657)
* **resize:** Fix legend resize ([7df949b](7df949b)), closes [#2650](#2650)
* **scale:** fix getting tickOffset ([3091677](3091677)), closes [#2669](#2669)
* **size.axis:** fix truncated axis when has no data ([40f4b66](40f4b66)), closes [#2675](#2675)
* **types:** Fix `Chart.load({ json })` typing ([1bd4f4a](1bd4f4a)), closes [#2711](#2711)
* **types:** Fix the signature of the tick format callback for timeseries ([c9c76e5](c9c76e5)), closes [#2676](#2676)
* **types:** Fix the type for options.data.names ([e64f6bd](e64f6bd)), closes [#2677](#2677)
* **types:** Fix types for the tooltip contents callback ([a0c0355](a0c0355)), closes [#2693](#2693)
* **zoom:** fix wheel zoom feeling "stuck" when panning past the edge ([50ed640](50ed640)), closes [#2588](#2588) [#2648](#2648)

### Features

* **area:** add option to render area below line ([cf60291](cf60291)), closes [#2740](#2740) [#2741](#2741)
* **data:** Intent to ship data.labels.rotate ([7b7ee08](7b7ee08)), closes [#2662](#2662)
* **option:** Intent to ship boost.useCssRule ([4a060d6](4a060d6)), closes [#2716](#2716)
* **option:** Intent to ship boost.useWorker ([eeaf8bd](eeaf8bd))
* **resize:** Intent to ship resize.timer ([#2712](#2712)) ([0a07de0](0a07de0)), closes [#2650](#2650)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@netil @michkami