Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.4.0 version does not work in IE. #2637

Closed
jiniC opened this issue Apr 13, 2022 · 2 comments
Closed

3.4.0 version does not work in IE. #2637

jiniC opened this issue Apr 13, 2022 · 2 comments
Labels
bug patch

Comments

@jiniC
Copy link

jiniC commented Apr 13, 2022 •
edited
Loading

Hello! As the supported browser says ie 9+, I report an issue.

I can't know the exact cause by checking the edge browser ie mode view in the window 11 environment,
but the billboard doesn't seem to work in ie.

All charts on the demo site are not exposed, and the error appears even in the environment I'm working on. There are few ie users, but I think there will be users or developers with the same error as me before ie support ends on June 25, 22.

If billboard.js no longer supports the ie environment, it seems that the written description needs to be updated.
Please confirm.
@netil netil added the bug label Apr 14, 2022
@netil
Copy link
Member

netil commented Apr 14, 2022 •
edited
Loading

Hi @jiniC, billboard.js has supported legacy browsers for a long period, but as the whole ecosystem and even MS announced the EOL of IE as you mentioned.
Basically, our direction is to provide as broad compatibility as we can, but it isn't an easy task.

We'll provide a fix for this for now, but consider that in a near future dropping the support for legacy browser is inevitable.

All charts on the demo site are not exposed,

The d3.js used on demo page, is v7 and it doesn't support legacy browser.

@netil netil added the patch label Apr 14, 2022
netil added a commit to netil/billboard.js that referenced this issue Apr 14, 2022
@netil
fix(point,util): fix syntax to work on legacy browser
d904df0 
- Make .inputType() to return 'mouse' if haven't detected any.
- Degrade the use of DOM APIs which isn't supported for legacy browser.

Ref naver#2637
@netil netil mentioned this issue Apr 14, 2022
Merged
@netil netil closed this as completed in 77798af Apr 14, 2022
@jiniC
Copy link
Author

jiniC commented Apr 14, 2022

Thank you for your confirmation!

github-actions bot pushed a commit that referenced this issue Apr 14, 2022
@semantic-release-bot
chore(release): 3.4.1 [skip ci]
8d1724b 
## [3.4.1](3.4.0...3.4.1) (2022-04-14)

### Bug Fixes

* **point,util:** fix syntax to work on legacy browser ([77798af](77798af)), closes [#2637](#2637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug patch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@netil @jiniC