Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong rendering for bar with clipPath + bar.radius options combination #2421

Closed
netil opened this issue Nov 18, 2021 · 0 comments
Closed

Wrong rendering for bar with clipPath + bar.radius options combination #2421

netil opened this issue Nov 18, 2021 · 0 comments
Assignees
Labels

Comments

@netil
Copy link
Member

netil commented Nov 18, 2021

Description

Given below option with the combination of clipPath + bar.radius options, bar with 0 data, will be broken as shown as the screenshot.

bb.generate({
    data: {
        columns: [
        ["data", 30, 0, 100],
        ],
        type: "bar"
    },
    clipPath: false,
    bar: {
        radius: {
        ratio: 0.2
        }
    }
});

Improve not applying radius for bar type when data is 0.

@netil netil added the bug label Nov 18, 2021
@netil netil self-assigned this Nov 18, 2021
netil added a commit to netil/billboard.js that referenced this issue Nov 18, 2021
- Make 0(zero) value to not apply Arc path command
- When clipPath=false is set, add clip-path attribute to bar element

Ref naver#2421
@netil netil closed this as completed in 80bf491 Nov 18, 2021
github-actions bot pushed a commit that referenced this issue Nov 19, 2021
## [3.2.2](3.2.1...3.2.2) (2021-11-19)

### Bug Fixes

* **api:** Fix zoom reset for  regions(), grids() api call ([679ce73](679ce73)), closes [#2411](#2411)
* **bar:** fix bar radius rendering with clipPath=false option ([80bf491](80bf491)), closes [#2421](#2421)
* **legend:** Fix usePoint option work for spaced data name ([275c1cc](275c1cc)), closes [#2425](#2425)
* **types:** fix candlestick data type ([ccac60d](ccac60d)), closes [#2422](#2422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant