Using "total" as field in bar chart, the width of the bar specific to "total" becomes 0, when max-width property is set. #1818
Labels
Comments
|
Hi @SowmithYatam, thanks for the report. |
netil
added a commit
to netil/billboard.js
that referenced
this issue
Dec 11, 2020
When given data name key includes 'total', it wrongly refers internal bar width data key where ends not rendering correclty. To avoid, added '_$' as prefix for internal object key names. Ref naver#1818
github-actions bot
pushed a commit
that referenced
this issue
Dec 24, 2020
# [2.2.0-next.1](2.1.4...2.2.0-next.1) (2020-12-24) ### Bug Fixes * **axis:** rotated horizontal xAxisHeight is calculated correctly after loading new data ([ef2754f](ef2754f)), closes [#1786](#1786) [#1787](#1787) * **bar:** fix bar width rendering for 'total' data key ([eacaecb](eacaecb)), closes [#1818](#1818) * **browser:** fix referencing global order ([8f84cb3](8f84cb3)), closes [#1778](#1778) * **browser:** fix retrieving global ([3474ac0](3474ac0)), closes [#1826](#1826) * **eventRect:** fix data.onclick work for scatter/bubble ([109c87d](109c87d)), closes [#1795](#1795) ### Features * **data:** Intent to ship data.label multiline ([8903aa6](8903aa6)), closes [#1784](#1784) * **gauge:** Intent to ship gauge.background ([632c600](632c600)), closes [#1804](#1804) * **pie:** Intent to ship pie.outerRadius ([ca67418](ca67418)), closes [#1825](#1825)
github-actions bot
pushed a commit
that referenced
this issue
Dec 24, 2020
# [2.2.0-next.3](2.2.0-next.2...2.2.0-next.3) (2020-12-24) ### Bug Fixes * **bar:** fix bar width rendering for 'total' data key ([eacaecb](eacaecb)), closes [#1818](#1818) * **browser:** fix retrieving global ([3474ac0](3474ac0)), closes [#1826](#1826) ### Features * **pie:** Intent to ship pie.outerRadius ([ca67418](ca67418)), closes [#1825](#1825)
github-actions bot
pushed a commit
that referenced
this issue
Jan 26, 2021
# [2.2.0](2.1.4...2.2.0) (2021-01-26) ### Bug Fixes * **api:** fix incorrect legend text positioning ([f1ede3f](f1ede3f)), closes [#1888](#1888) * **api:** fix zoom for timesries axis ([0421a50](0421a50)), closes [#1868](#1868) * **arc:** fix setting color value ([fad9e86](fad9e86)), closes [#1857](#1857) [#1847](#1847) * **axis:** fix incorrect tick interval calculation ([1a96f3e](1a96f3e)), closes [#1896](#1896) * **axis:** rotated horizontal xAxisHeight is calculated correctly after loading new data ([ef2754f](ef2754f)), closes [#1786](#1786) [#1787](#1787) * **bar:** fix bar width on zoom ([25e987a](25e987a)), closes [#1907](#1907) * **bar:** fix bar width rendering for 'total' data key ([eacaecb](eacaecb)), closes [#1818](#1818) * **browser:** fix referencing global order ([8f84cb3](8f84cb3)), closes [#1778](#1778) * **browser:** fix retrieving global ([3474ac0](3474ac0)), closes [#1826](#1826) * **color:** fix color callback mismatch ([86ef214](86ef214)), closes [#1847](#1847) * **data:** fix data.order to work for arc types ([3a716a0](3a716a0)), closes [#1863](#1863) * **eventrect:** fix resizing event rect element after .load() ([12bf547](12bf547)), closes [#1864](#1864) * **eventRect:** fix data.onclick work for scatter/bubble ([109c87d](109c87d)), closes [#1795](#1795) * **point:** fix usePoint defs id value ([6df4653](6df4653)), closes [#1887](#1887) * **radar:** fix data label text position ([c69d674](c69d674)), closes [#1871](#1871) * **text:** data labels are working in Internet Explorer again ([865224e](865224e)), closes [#1877](#1877) * **tooltip:** fix arc's tooltip interaction ([a8586a3](a8586a3)), closes [#1859](#1859) * **types:** fix .load() data type ([7108e7b](7108e7b)), closes [#1848](#1848) ### Features * **api:** make return values for axis.labels() ([efa5174](efa5174)), closes [#1865](#1865) * **data:** Intent to ship data.label multiline ([8903aa6](8903aa6)), closes [#1784](#1784) * **data.labels.colors:** Add callback support ([ac1affa](ac1affa)), closes [#1845](#1845) * **gauge:** added support for drawing gauge from 'startingAngle' to 'arcLength' ([25954ad](25954ad)), closes [#1633](#1633) [#1803](#1803) [#1849](#1849) * **gauge:** Intent to ship gauge.background ([632c600](632c600)), closes [#1804](#1804) * **pie:** Intent to ship pie.outerRadius ([ca67418](ca67418)), closes [#1825](#1825) * **point:** Intent to ship point.opacity ([fc5ad35](fc5ad35)), closes [#1867](#1867)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
I have investigated in the billboard.js code and figured out that“total” is used as keyword in a specific structure, which in combination with max width setting, ends up in 0 width for that specific bar instead of the value set.
the issue is in generateGetBarPoints method.
Method $$.getBarW(axis, barTargetsNum) inside generateGetBarPoints returns a number if max width is not set, while it returns this structure {width: result, total: []} if max width is set.
Steps to check or reproduce
https://codesandbox.io/s/simple-billboardjs-line-chart-forked-cqmro?file=/src/Hello.js
The text was updated successfully, but these errors were encountered: