Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 - chart bars are not rendered when unselecting some bars #1758

Closed
creage opened this issue Nov 3, 2020 · 2 comments
Closed

IE11 - chart bars are not rendered when unselecting some bars #1758

creage opened this issue Nov 3, 2020 · 2 comments

Comments

@creage
Copy link

creage commented Nov 3, 2020

Description

In IE11, when rendering a Bar chart with huge numbers, and later hiding this big bar by clicking on it's legend title - chart does not render the rest of the bars.

Steps to check or reproduce

Using IE11, go to the Examples page https://naver.github.io/billboard.js/demo/#Chart.BarChart, and replace the code with the one below

var chart = bb.generate({
  data: {
   columns: [
     ["a", 34.21],
     ["b", 0],
     ["c", -306.86],
     ["unselect me", -99999999999],
     ["e", -989],
     ["f", 0]
    ],
    type: "bar"
  },
  bar: {
    width: {
      ratio: 0.5
    }
  },
  bindto: "#barChart"
});

Now click on unselect me label in chart's legend. I expect the rest of the bars to gain their actual height proportionally, as they do in Chrome browser.

@netil
Copy link
Member

netil commented Nov 6, 2020

confirmed the issue, but hard to determine what is the cause.
same path definition works when generate without unselect me data, but not appearing when is together.

Seems the IE's issue, but need to spend time for workaround.

netil added a commit to netil/billboard.js that referenced this issue Nov 9, 2020
When dataseries is hidden, set 'display:none' to fix
certain data values of bar shape is not correctly shown
on ie11.

Ref naver#1758
@netil netil closed this as completed in d1366d1 Nov 9, 2020
@netil
Copy link
Member

netil commented Nov 9, 2020

Applying display:none for the hidden dataseries element's node will fix the issue.

The current opacity property approach works when data range is ["unselect me", -9999999],.
Weird behavior, but is not surprising how IE behaves weirdly in many occasions.

netil pushed a commit that referenced this issue Nov 11, 2020
## [2.1.4](2.1.3...2.1.4) (2020-11-11)

### Bug Fixes

* **api:** fix tooltip showing when lesser data loaded ([74320cf](74320cf)), closes [#1761](#1761)
* **event:** fix referencing event element ([38568c1](38568c1)), closes [#1752](#1752)
* **gauge:** fix to be consistent max label value ([0c2006f](0c2006f)), closes [#1759](#1759)
* **radar:** fix labels showing on esm usage ([d56ff52](d56ff52)), closes [#1765](#1765)
* **shape:** shape not showing on ie11 ([d1366d1](d1366d1)), closes [#1758](#1758)
* **tooltip:** fix to reset pending events from .show() ([ce8210c](ce8210c)), closes [#1753](#1753)
* **zoom:** fix throwing TypeError during zoom  ([f2787fa](f2787fa)), closes [#1760](#1760)
@netil netil added the released label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants