Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaced data name with point pattern cause error #1739

Closed
netil opened this issue Oct 23, 2020 · 0 comments
Closed

Spaced data name with point pattern cause error #1739

netil opened this issue Oct 23, 2020 · 0 comments
Labels

Comments

@netil
Copy link
Member

netil commented Oct 23, 2020

Description

When data name contains space and custom pattern data point is used, it case error.

Steps to check or reproduce

bb.generate({
  data: {
    columns: [
		["data 1", 100, 400, 1000, 900, 500],
    ],
    type: "line"
  },
  point: {
    pattern: [
      "<path d='m3.937502,2.348755c1.314192,-3.618047 6.463238,0 0,4.651779c-6.463238,-4.651779 -1.314192,-8.269826 0,-4.651779z' />"
    ]
  }
});
@netil netil added the bug label Oct 23, 2020
netil added a commit to netil/billboard.js that referenced this issue Oct 23, 2020
Convert id value using .getTargetSelectorSuffix() to prevent
node query selection error.

Ref naver#1739
@netil netil closed this as completed in 6ff9aec Oct 23, 2020
netil pushed a commit that referenced this issue Oct 23, 2020
## [2.1.3](2.1.2...2.1.3) (2020-10-23)

### Bug Fixes

* **event:** Fix handling for single x Axis data ([84eaa6b](84eaa6b)), closes [#1737](#1737)
* **point:** fix error when data has spaced name ([6ff9aec](6ff9aec)), closes [#1739](#1739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant