Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shape): Fix incorrect area/bar rendering #1323

Merged
merged 1 commit into from
Apr 10, 2020
Merged

fix(shape): Fix incorrect area/bar rendering #1323

merged 1 commit into from
Apr 10, 2020

Conversation

netil
Copy link
Member

@netil netil commented Apr 10, 2020

Issue

#1316

Details

@netil
fix(shape): Fix incorrect area/bar rendering
0010766 
Fix side-effect caused by #1304, making to return y Axis base value based on the current y Axis scale value.
Make sure this to used only non-grouped data and for y Axis min is greater than 0.

Ref #1316
@netil netil added the bug label Apr 10, 2020
@netil netil self-assigned this Apr 10, 2020
@netil netil merged commit 9f81fb2 into naver:master Apr 10, 2020
@netil
Copy link
Member Author

netil commented Apr 10, 2020

🎉 This PR is included in version 1.12.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@netil netil added the released label Apr 10, 2020
netil added a commit that referenced this pull request Apr 19, 2020
@netil
skip: merge #1323 and fix tests on internals/data-spec.ts
92eb236 
- Rename test/shape/shape.*.ts, removing 'shape.' prefix
- Fix data label text rendering for null data value
@netil netil deleted the barArea#1316 branch April 29, 2020 07:18
netil added a commit to netil/billboard.js that referenced this pull request Jan 25, 2022
@netil
fix(axis): Fix bar draw for inverted y/y2 axes
a507f1f 
Update getting y/y2 axes min value.
Side effect caused by naver#1323

Ref naver#2503
@netil netil mentioned this pull request Jan 25, 2022
Merged
netil added a commit that referenced this pull request Jan 26, 2022
@netil
fix(axis): Fix bar draw for inverted y/y2 axes
9d0fb70 
Update getting y/y2 axes min value.
Side effect caused by #1323

Fix #2503
github-actions bot pushed a commit that referenced this pull request Jan 28, 2022
@semantic-release-bot
chore(release): 3.3.1 [skip ci]
0164719 
## [3.3.1](3.3.0...3.3.1) (2022-01-28)

### Bug Fixes

* **axis:** Fix bar draw for inverted y/y2 axes ([9d0fb70](9d0fb70)), closes [#1323](#1323) [#2503](#2503)
* **domain:** Fix incorrect domain updates ([a697b69](a697b69)), closes [#2523](#2523)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@netil netil

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@netil