Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTERNAL: separate usage of subkey and bkey/mkey #525

Merged
merged 1 commit into from
Jul 21, 2022
Merged

INTERNAL: separate usage of subkey and bkey/mkey #525

merged 1 commit into from
Jul 21, 2022

Conversation

oliviarla
Copy link
Collaborator

@oliviarla oliviarla commented Jul 21, 2022 •
edited
Loading

#521

  • CollectionAsync...와 같이 여러 Collection과 관련된 메소드는 subkey 용어를 사용합니다.
  • AsyncBopIncr, AsyncMopGet과 같이 하나의 Collection과 관련된 메소드는 각 Collection에서 사용 되는 키(bkey, mkey)를 용어로 사용합니다.
  • 문서는 수정할 것이 크게 없어 오타 수정만 하였습니다.

jhpark816
jhpark816 reviewed Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료

src/main/java/net/spy/memcached/ArcusClientIF.java Outdated
@@ -1911,92 +1911,92 @@ public <T> CollectionGetBulkFuture<Map<String, BTreeGetResult<Long, T>>> asyncBo
* Increment the element's value in b+tree.
*
* @param key b+tree item's key
* @param subkey element's key
* @param bkey element's key
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

param 명과 설명 사이의 간격 유지 필요.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전부 간격 수정 하였습니다 :)

@jhpark816 jhpark816 merged commit 928ebf3 into naver:develop Jul 21, 2022
@jhpark816
Copy link
Collaborator

@sUpniverse 수정 사항 확인하고, 문제 있으면 알려주세요.

@oliviarla oliviarla deleted the bkey_subkey branch September 4, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhpark816 jhpark816 jhpark816 left review comments

@sUpniverse sUpniverse Awaiting requested review from sUpniverse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviarla @jhpark816