Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node and React plugins #6

Merged
merged 4 commits into from
Oct 2, 2017
Merged

Update Node and React plugins #6

merged 4 commits into from
Oct 2, 2017

Conversation

sawyerh
Copy link
Contributor

@sawyerh sawyerh commented Oct 2, 2017

Changes

Testing

  • Tested against the design system codebase successfully

@sawyerh sawyerh requested a review from kencheeto October 2, 2017 17:02
kencheeto
kencheeto approved these changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@kencheeto kencheeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 should there be an update to the package-lock.json file? if you're using npm 5, that should happen automatically.

@sawyerh
Copy link
Contributor Author

sawyerh commented Oct 2, 2017

@kencheeto Good catch. Just ran npm install to update that file. Does that sound right? (I haven't used npm5 much yet).

@kencheeto
Copy link
Contributor

yep, perfect! :shipit:

@sawyerh sawyerh merged commit bdf4f62 into master Oct 2, 2017
@sawyerh sawyerh deleted the sawyerh/update-deps branch October 2, 2017 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kencheeto kencheeto kencheeto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sawyerh @kencheeto