Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5232 add grouping support for computed fields #6059

Merged
merged 11 commits into from
Aug 9, 2024
Merged

5232 add grouping support for computed fields #6059

merged 11 commits into from
Aug 9, 2024

Conversation

Renrut5
Copy link
Contributor

@Renrut5 Renrut5 commented Aug 6, 2024 •
edited
Loading

Closes #5232

What's Changed

Groupings support added for computed fields, similar to Custom Fields.

Screenshots

image
image

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example App Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@Renrut5 Renrut5 marked this pull request as draft August 6, 2024 20:30
glennmatthews
glennmatthews reviewed Aug 6, 2024
View reviewed changes
changes/5232.added Outdated Show resolved Hide resolved
nautobot/core/templates/generic/object_retrieve.html Show resolved Hide resolved
nautobot/extras/forms/forms.py Show resolved Hide resolved
@Renrut5 Renrut5 marked this pull request as ready for review August 9, 2024 15:22
@Renrut5 Renrut5 requested a review from glennmatthews August 9, 2024 15:22
HanlinMiao
HanlinMiao approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@HanlinMiao HanlinMiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@glennmatthews glennmatthews merged commit 96354c4 into nautobot:develop Aug 9, 2024
17 checks passed
@Renrut5 Renrut5 deleted the 5232-add-grouping-support-for-computed-fields branch August 15, 2024 18:47
alextremblay pushed a commit to utsc-networking/nautobot that referenced this pull request Sep 30, 2024
@Renrut5 @alextremblay
5232 add grouping support for computed fields (nautobot#6059)
7a2094e 
* Add grouping field

* Add groupings functionality for computed fields

* Add changelog fragment

* Update changelog fragment

* Update template calls

* Add grouping filters

* fix lint

* merge and rename migration

* redo migrations

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HanlinMiao HanlinMiao HanlinMiao approved these changes

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add grouping support for Computed Fields
3 participants
@Renrut5 @glennmatthews @HanlinMiao