Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 Pydantic errors and field normalization issues #615

Merged
merged 4 commits into from
Dec 6, 2024
Merged

fix: 🐛 Pydantic errors and field normalization issues #615

merged 4 commits into from
Dec 6, 2024

Conversation

bile0026
Copy link
Contributor

@bile0026 bile0026 commented Dec 5, 2024 •
edited
Loading

Closes: #614

What's Changed

Fix Pydantic errors
Allow creation of platforms with no manufacturer assigned.
Fix improper normalization on time_zone attribute on Location objects.

To Do

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@bile0026 bile0026 requested a review from a team as a code owner December 5, 2024 22:39
@bile0026 bile0026 added type: bug Issues/PRs addressing a bug. integration: bootstrap Issues/PRs for Bootstrap integration labels Dec 5, 2024
@bile0026 bile0026 marked this pull request as draft December 5, 2024 22:39
@bile0026 bile0026 changed the title fix: 🐛 handle platforms with no manufacturer fix: 🐛 Pydantic errors and field normalization issues Dec 6, 2024
@bile0026 bile0026 marked this pull request as ready for review December 6, 2024 17:14
@bile0026 bile0026 requested a review from jdrew82 December 6, 2024 17:15
jdrew82
jdrew82 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bile0026 bile0026 merged commit ab1c9e2 into develop Dec 6, 2024
15 checks passed
@bile0026 bile0026 deleted the bootstrap_fix_614 branch December 6, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrew82 jdrew82 jdrew82 approved these changes

Assignees
No one assigned
Labels
integration: bootstrap Issues/PRs for Bootstrap integration type: bug Issues/PRs addressing a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pydantic validation errors for Bootstrap objects
2 participants
@bile0026 @jdrew82