Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves error message for contrib validated save #590

Merged

Conversation

Kircheneer
Copy link
Contributor

@Kircheneer Kircheneer commented Oct 28, 2024

Without this the actual error message is swallowed, making it very hard to debug validation errors.

@Kircheneer Kircheneer self-assigned this Oct 28, 2024
@Kircheneer Kircheneer requested a review from a team as a code owner October 28, 2024 12:24
@Kircheneer Kircheneer force-pushed the improve-contrib-error-messaging branch from f223f45 to 0f2c3dc Compare October 28, 2024 12:24
Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kircheneer Kircheneer merged commit 5c714a1 into nautobot:develop Oct 28, 2024
15 checks passed
Kircheneer added a commit to Kircheneer/nautobot-plugin-ssot that referenced this pull request Oct 28, 2024
…-messaging

improves error message for contrib validated save
jdrew82 added a commit that referenced this pull request Oct 28, 2024
…saging

[LTM] Improved contrib error messaging (backport #590)
@jdrew82 jdrew82 mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants