Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common TypedDicts used for M2M #565

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

Renrut5
Copy link
Contributor

@Renrut5 Renrut5 commented Oct 8, 2024

Add common TypedDicts for use with many-to-many and one-to-many relationships.

@Renrut5 Renrut5 requested a review from a team as a code owner October 8, 2024 20:37
@Renrut5 Renrut5 linked an issue Oct 8, 2024 that may be closed by this pull request
@jdrew82 jdrew82 added the integration: contrib Contrib related issues and PRs label Oct 21, 2024
@Kircheneer
Copy link
Contributor

Thanks for the contribution! Can you add some docs that show why these exist and how to use them?

@jdrew82
Copy link
Contributor

jdrew82 commented Oct 21, 2024

@Renrut5 Can you please update your initial comment to explain what this PR is for? Also, like @Kircheneer , can we get some documentation around these? I think it'd make sense to include these in the Modeling or Developer section(s)?

@Renrut5 Renrut5 requested a review from bile0026 as a code owner October 29, 2024 19:31
@Renrut5
Copy link
Contributor Author

Renrut5 commented Oct 29, 2024

@jdrew82 @Kircheneer added some docs. Kept it simple and right under where it introduces typed dicts.

Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82 jdrew82 merged commit 17b9959 into develop Oct 29, 2024
15 checks passed
@jdrew82 jdrew82 deleted the 310-aturner-add-common-typeddicts branch October 29, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: contrib Contrib related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add common TypedDicts used for M2M into contrib.py
3 participants