Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap ssot integration #541

Merged
merged 21 commits into from
Oct 4, 2024
Merged

Bootstrap ssot integration #541

merged 21 commits into from
Oct 4, 2024

Conversation

bile0026
Copy link
Contributor

Add Bootstrap SSoT to sync in information from a local yaml file or git repository hosting information for various Nautobot "base" models.

@bile0026 bile0026 requested a review from a team as a code owner September 10, 2024 12:52
@bile0026 bile0026 mentioned this pull request Sep 10, 2024
@Kircheneer
Copy link
Contributor

Kircheneer commented Sep 10, 2024

Looks much better

@jdrew82 jdrew82 added type: major feature integration: bootstrap Issues/PRs for Bootstrap integration labels Sep 11, 2024
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some items to address.

docs/admin/integrations/bootstrap_setup.md Outdated Show resolved Hide resolved
docs/admin/integrations/bootstrap_setup.md Outdated Show resolved Hide resolved
docs/admin/integrations/bootstrap_setup.md Outdated Show resolved Hide resolved
docs/admin/integrations/bootstrap_setup.md Outdated Show resolved Hide resolved
docs/admin/integrations/bootstrap_setup.md Outdated Show resolved Hide resolved
docs/admin/integrations/bootstrap_setup.md Outdated Show resolved Hide resolved
nautobot_ssot/integrations/bootstrap/constants.py Outdated Show resolved Hide resolved
nautobot_ssot/integrations/bootstrap/jobs.py Outdated Show resolved Hide resolved
nautobot_ssot/integrations/bootstrap/jobs.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some stuff to address.

docs/admin/integrations/bootstrap_setup.md Outdated Show resolved Hide resolved
nautobot_ssot/integrations/bootstrap/constants.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick to the docs. Also, I think you need to add yourself to the CODEOWNERS for this integration.

docs/admin/integrations/bootstrap_setup.md Outdated Show resolved Hide resolved
@jdrew82
Copy link
Contributor

jdrew82 commented Oct 3, 2024

Also, please fix conflict with release notes for 1.5.

Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82 jdrew82 merged commit a163448 into develop Oct 4, 2024
14 checks passed
@jdrew82 jdrew82 deleted the bootstrap_ssot_integration branch October 4, 2024 16:40
@jdrew82 jdrew82 mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: bootstrap Issues/PRs for Bootstrap integration type: major feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants