Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Upstream Monitor CI #490

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Fix Upstream Monitor CI #490

merged 1 commit into from
Jul 25, 2024

Conversation

jdrew82
Copy link
Contributor

@jdrew82 jdrew82 commented Jul 25, 2024

This PR closes #489 and fixes the failing test.

@jdrew82 jdrew82 self-assigned this Jul 25, 2024
@jdrew82 jdrew82 requested a review from a team as a code owner July 25, 2024 16:47
glennmatthews
glennmatthews reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a replacement value that should be used, instead of deleting this line altogether?

@jdrew82
Copy link
Contributor Author

jdrew82 commented Jul 25, 2024

Is there a replacement value that should be used, instead of deleting this line altogether?

This was the solution we used when the same bug came up in the 2.x release here. Netmiko doesn't actually support BIG-IP so it's an unnecessary test.

@jdrew82 jdrew82 merged commit 622d506 into ltm-1.6 Jul 25, 2024
9 of 14 checks passed
@jdrew82 jdrew82 deleted the patch-489 branch July 25, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees

@jdrew82 jdrew82

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdrew82 @glennmatthews