Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct CVP Integration Call to get_devices() #464

Merged
merged 1 commit into from
May 30, 2024
Merged

Correct CVP Integration Call to get_devices() #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/463.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed call in CVP integration to pass `import_active` config setting to get_devices() function call.
4 changes: 3 additions & 1 deletion nautobot_ssot/integrations/aristacv/diffsync/adapters/cloudvision.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ def load_devices(self):
except ObjectAlreadyExists as err:
self.job.logger.warning(f"Error attempting to add CloudVision device. {err}")

for index, dev in enumerate(cloudvision.get_devices(client=self.conn.comm_channel), start=1):
for index, dev in enumerate(
cloudvision.get_devices(client=self.conn.comm_channel, import_active=config.import_active), start=1
):
if self.job.debug:
self.job.logger.info(f"Loading {index}° device")
if dev["hostname"] != "":
Expand Down