Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infoblox] Replace requests.request with requests.Session in the Infoblox API client. #438

Merged
merged 4 commits into from
Apr 25, 2024
Merged

[Infoblox] Replace requests.request with requests.Session in the Infoblox API client. #438

merged 4 commits into from
Apr 25, 2024

Conversation

progala
Copy link
Contributor

@progala progala commented Apr 25, 2024

Changed the Infoblox utils.client to make API calls using requests.Session instead of requests.request.

This change should result in 1.5 - 3x performance improvement when loading data from Infoblox.

@progala progala requested review from qduk, jdrew82 and a team as code owners April 25, 2024 13:15
@jdrew82 jdrew82 added type: enhancement New feature or request integration: infoblox Issues/PRs for Infoblox integration labels Apr 25, 2024
jdrew82
jdrew82 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82 jdrew82 merged commit a42ab6f into nautobot:develop Apr 25, 2024
16 checks passed
@progala progala mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrew82 jdrew82 jdrew82 approved these changes

@qduk qduk Awaiting requested review from qduk qduk is a code owner

Assignees
No one assigned
Labels
integration: infoblox Issues/PRs for Infoblox integration type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@progala @jdrew82